New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] OONI Run v2 #564

Open

aanorbel wants to merge 4 commits into master from dev/ooni-run-v2

Member

aanorbel commented Jun 19, 2024 •

edited by bassosimone

Loading

Proposed Changes

Internal refactoring to enable use of descriptor format in application core. d0ffa8e


          feat: internal refactoring to enable use of descriptor format in appl…

d0ffa8e

…ication core.

bassosimone reviewed

View reviewed changes

Contributor

bassosimone left a comment

I mainly have questions about commented out code

ooniprobe/View/RunTest/TestOverviewViewController.m Show resolved Hide resolved

ooniprobe/View/RunTest/TestOverviewViewController.m Outdated Show resolved Hide resolved

ooniprobe/View/RunTest/TestOverviewViewController.m Outdated Show resolved Hide resolved

ooniprobe/View/RunTest/TestOverviewViewController.m Outdated Show resolved Hide resolved

aanorbel and others added 3 commits

June 24, 2024 14:00


          fix: update based on PR review

b78e750


          feat (OONI Run v2): Update Dashboard view to match new design (#556)

0ef1aea

Fixes ooni/ooni.org#1512


## Proposed Changes

  - Update storyboard to match designs
  - Update `DashboardTableViewCell` definition to fine-tune views
 
|.|.|
|-|-|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-02-27 at 21 09
40](https://github.com/ooni/probe-ios/assets/17911892/8fab41df-703e-49c5-90c6-7921173460be)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-02-27 at 21 09
52](https://github.com/ooni/probe-ios/assets/17911892/334fa805-37af-4027-9ea7-fbecf033d944)
|


          feat (OONI Run v2): update preference screens to match new designs (#563

fd7bbaf

)

Fixes ooni/ooni.org#1516

## Proposed Changes

  - Updated Preference view.
  - Remove cell separators.

|.|.|.|
|-|-|-|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 16
22](https://github.com/ooni/probe-ios/assets/17911892/da283012-625f-4aae-a679-2c0e81240ef9)|
![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 16
27](https://github.com/ooni/probe-ios/assets/17911892/65429962-8fe5-4274-ac4a-377b9db6c40e)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 16
31](https://github.com/ooni/probe-ios/assets/17911892/6508f17d-cca2-4364-93c2-b6cdae21d443)
|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 16
36](https://github.com/ooni/probe-ios/assets/17911892/861ae3db-3707-4442-a567-300983434b32)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 16
42](https://github.com/ooni/probe-ios/assets/17911892/63c8f7a5-5ca2-4abc-acc4-3daa28881bea)
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 16
58](https://github.com/ooni/probe-ios/assets/17911892/2ec2163e-28c8-4b3b-bb0d-db4abd9bc07b)
|
| ![Simulator Screenshot - iPhone 15 Pro Max - 2024-06-17 at 12 17
04](https://github.com/ooni/probe-ios/assets/17911892/e152614c-d4bc-4115-9eea-54e284ed2254)
|. |.|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet