-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose 1.8 #1558
Open
Him188
wants to merge
8
commits into
main
Choose a base branch
from
him188/compose-1.8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compose 1.8 #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Him188
commented
Jan 22, 2025
app/shared/video-player/src/commonMain/kotlin/ui/guesture/PlayerGestureHost.kt
Show resolved
Hide resolved
…nt color change. Affected: - MediaSelectorFilterChip - SubjectCollectionTypeButton - MediaSourceResultCard
…ntroller for a while
Him188
force-pushed
the
him188/compose-1.8
branch
from
January 22, 2025 13:14
e537704
to
9024e8e
Compare
ping @StageGuard this may block all other PRs |
no conflict |
我在等你 review(你之前说要测一下) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMP 1.8.0-alpha02
显著变更:
animeko/app/shared/src/desktopTest/kotlin/ui/subject/episode/EpisodeVideoControllerTest.kt
Lines 604 to 614 in e537704
need #1556