-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sg/wizard with steps #1572
Draft
StageGuard
wants to merge
95
commits into
main
Choose a base branch
from
sg/wizard-with-steps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Sg/wizard with steps #1572
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
4b148d3
wizard host
StageGuard be94435
fix
StageGuard 2b55d6b
remove TestOnly
StageGuard 9d720ae
update
StageGuard 0494491
box states
StageGuard f6c85c2
Don't handle wizard data at controller.
StageGuard acdbb4b
rename builder to scope
StageGuard 5e9a142
remember
StageGuard 24a7eb3
remove flow extension
StageGuard ae75a1d
add doc
StageGuard 70bb7c6
Don't handle any data
StageGuard 074d7f8
add transition animation
StageGuard 9cf51dd
extract scaffold bars
StageGuard adc8574
fix
StageGuard 70bdbaf
add content to disposable key
StageGuard e0d0637
scrollable
StageGuard e3c40d2
replace `scrollable` to `verticalScroll`
StageGuard d63d3f9
commit current
StageGuard 9222034
add UI test for WizardNavHost
StageGuard a87c6ff
Merge branch 'sg/wizard' into sg/wizard-with-steps
StageGuard aed018d
remove WizardHostTest
StageGuard d5067c9
Merge branch 'main' into sg/wizard-with-steps
StageGuard 380337f
derive `currentProxyTestMode` from `proxyConfig`
StageGuard 80f0955
Merge branch 'main' into sg/wizard-with-steps
StageGuard 4d40857
apply theme
StageGuard 8879dca
commonize `SystemBarColorEffect`
StageGuard 34c9869
adapt status bar color
StageGuard 9dc0c27
optimize
StageGuard 57087ef
bit torrent step
StageGuard 4104c82
bit torrent step
StageGuard 446178d
fix jdk usage
StageGuard 0b7f926
do not depend on WindowAdaptiveInfo
StageGuard cdf1834
combine states
StageGuard 8fc8c90
immediately apply settings in wizard.
StageGuard 44bbf73
missing param
StageGuard dbda25d
bangumi authorize page
StageGuard 2a3a140
contact actions
StageGuard 2f94acc
adjust icon color
StageGuard 0b5215f
handle vertical scroll by step-self
StageGuard 7b75879
logic for authorize
StageGuard 906aad9
Merge branch 'main' into sg/wizard-with-steps
StageGuard c561c3d
update
StageGuard fa901bd
auto scroll down after waiting for 60s to get authorization result
StageGuard 93d4d28
add skip button
StageGuard 6c3fbf1
㱇 guest session
StageGuard 7a12fc4
emit guest session branch
StageGuard fff28c2
click item
StageGuard c7568f5
auth via token
StageGuard b04b4ce
optimize
StageGuard 166521f
move icon to foundation
StageGuard fc2468c
stateInBackground
StageGuard 04fd1f1
New wizard host: remove pinned bottom control bar
StageGuard 300ea35
adapt large top app bar
StageGuard 346462a
restore
StageGuard b74d0a6
Merge branch 'main' into sg/wizard-with-steps
StageGuard 66c5487
adapt new client provider
StageGuard 9d3786a
adapt new client provider
StageGuard f8b407e
Merge branch 'main' into sg/wizard-with-steps
StageGuard b21cb03
Merge branch 'main' into sg/wizard-with-steps
StageGuard ac3f15f
use local navigation motion scheme
StageGuard 8d27ed4
don't show dynamic color settings on non-Android
StageGuard e51b7c6
provide list state via `WizardStepScope` for steps
StageGuard 5655e89
optimize BangumiAuthorize page
StageGuard a673691
optimize token authorize
StageGuard e144b77
move QA expand button to right
StageGuard c83ae9e
group
StageGuard 7e4943e
remove `HeroScaffold`
StageGuard 5010c66
refactor colors
StageGuard a4be0f3
rename
StageGuard 778cd89
fix theme panel indicator
StageGuard 8131da7
change order of theme panel
StageGuard 40cfa57
extract ColorSchemePreviewItem
StageGuard c3cce5b
fix role of theme panel
StageGuard 8921cda
max 4 items
StageGuard e8eb7b8
Merge branch 'main' into sg/wizard-with-steps
StageGuard 0de9577
use AniMotionScheme
StageGuard b1ccc3f
migrate all UI state in ConfigureProxy step to ConfigureProxyUIState
StageGuard defebe4
add data layer of UI for ConfigureProxy step
StageGuard 17c15ec
add missing content description for icons
StageGuard 6f9403f
fix param name
StageGuard 0f2b843
Switch Item
StageGuard 67b0943
remove color changes
StageGuard 2df1e64
optimize ui
StageGuard e80ccb4
optimize clickable
StageGuard 6972c76
optimize first splash screen
StageGuard 110e0d1
rename itemVerticalSpace to itemVerticalSpacing
StageGuard 72de4a8
remove crossfade
StageGuard 9bdb875
rearrange
StageGuard c0d1aff
lambda argument name
StageGuard 4100ca5
fix scroll
StageGuard da73e85
fix
StageGuard c07100c
todo
StageGuard 89031fa
todo
StageGuard a27edcd
todo
StageGuard a4493ee
move ThemePreviewPanel and ColorButton to `ui-settings`
StageGuard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
app/shared/app-platform/src/commonMain/kotlin/platform/PermissionManager.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
app/shared/app-platform/src/commonMain/kotlin/ui/theme/Color.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
@file:JvmName("ColorKt_platform") | ||
/* | ||
* Copyright (C) 2024-2025 OpenAni and contributors. | ||
* | ||
* 此源代码的使用受 GNU AFFERO GENERAL PUBLIC LICENSE version 3 许可证的约束, 可以在以下链接找到该许可证. | ||
* Use of this source code is governed by the GNU AGPLv3 license, which can be found at the following link. | ||
* | ||
* https://github.com/open-ani/ani/blob/main/LICENSE | ||
*/ | ||
|
||
package me.him188.ani.app.ui.theme | ||
|
||
import androidx.compose.ui.graphics.Color | ||
import kotlin.jvm.JvmName | ||
|
||
// region Note: You should only add UI properties when it is accessed both `ui-foundation` and `app-data` | ||
|
||
val DefaultSeedColor = Color(0xFF4F378B) | ||
val AnimekoIconColor = Color(0, 88, 160) | ||
val BangumiNextIconColor = Color(240, 145, 153) | ||
|
||
// endregion |
38 changes: 33 additions & 5 deletions
38
app/shared/application/src/androidMain/kotlin/platform/AndroidPermissionManager.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
app/shared/ui-foundation/src/androidMain/kotlin/ui/theme/ColorButton.android.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright (C) 2024-2025 OpenAni and contributors. | ||
* | ||
* 此源代码的使用受 GNU AFFERO GENERAL PUBLIC LICENSE version 3 许可证的约束, 可以在以下链接找到该许可证. | ||
* Use of this source code is governed by the GNU AGPLv3 license, which can be found at the following link. | ||
* | ||
* https://github.com/open-ani/ani/blob/main/LICENSE | ||
*/ | ||
|
||
package me.him188.ani.app.ui.theme | ||
|
||
import androidx.compose.foundation.layout.FlowRow | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.runtime.getValue | ||
import androidx.compose.runtime.mutableStateOf | ||
import androidx.compose.runtime.remember | ||
import androidx.compose.runtime.setValue | ||
import androidx.compose.ui.tooling.preview.Preview | ||
import me.him188.ani.app.ui.foundation.ProvideFoundationCompositionLocalsForPreview | ||
import me.him188.ani.app.ui.foundation.theme.AniThemeDefaults | ||
|
||
@Preview | ||
@Composable | ||
fun PreviewColorButton() { | ||
ProvideFoundationCompositionLocalsForPreview { | ||
FlowRow { | ||
var currentColor by remember { mutableStateOf(AniThemeDefaults.themeColorOptions[0]) } | ||
AniThemeDefaults.themeColorOptions.forEach { | ||
me.him188.ani.app.ui.settings.tabs.theme.ColorButton( | ||
onClick = { currentColor = it }, | ||
baseColor = it, | ||
selected = currentColor == it, | ||
) | ||
} | ||
} | ||
} | ||
} |
42 changes: 42 additions & 0 deletions
42
app/shared/ui-foundation/src/androidMain/kotlin/ui/theme/ThemePreviewPanel.android.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright (C) 2024-2025 OpenAni and contributors. | ||
* | ||
* 此源代码的使用受 GNU AFFERO GENERAL PUBLIC LICENSE version 3 许可证的约束, 可以在以下链接找到该许可证. | ||
* Use of this source code is governed by the GNU AGPLv3 license, which can be found at the following link. | ||
* | ||
* https://github.com/open-ani/ani/blob/main/LICENSE | ||
*/ | ||
|
||
package me.him188.ani.app.ui.theme | ||
|
||
import androidx.compose.foundation.layout.Arrangement | ||
import androidx.compose.foundation.layout.Row | ||
import androidx.compose.foundation.layout.size | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.tooling.preview.Preview | ||
import androidx.compose.ui.unit.dp | ||
import me.him188.ani.app.ui.foundation.ProvideFoundationCompositionLocalsForPreview | ||
import me.him188.ani.app.ui.foundation.theme.appColorScheme | ||
|
||
@Preview | ||
@Composable | ||
fun PreviewThemePreviewPanel() { | ||
ProvideFoundationCompositionLocalsForPreview { | ||
Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) { | ||
me.him188.ani.app.ui.settings.tabs.theme.ThemePreviewPanel( | ||
colorScheme = appColorScheme(isDark = false), | ||
modifier = Modifier.size(96.dp, 146.dp), | ||
) | ||
me.him188.ani.app.ui.settings.tabs.theme.ThemePreviewPanel( | ||
colorScheme = appColorScheme(isDark = true), | ||
modifier = Modifier.size(96.dp, 146.dp), | ||
) | ||
me.him188.ani.app.ui.settings.tabs.theme.DiagonalMixedThemePreviewPanel( | ||
leftTopColorScheme = appColorScheme(isDark = false), | ||
rightBottomColorScheme = appColorScheme(isDark = true), | ||
modifier = Modifier.size(96.dp, 146.dp), | ||
) | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use a constructor-like a function to construct a ProxySettingsFlowProxyProvider instead of making a type.