Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move paraview_hello_world notebook from examples to HOWTOs; add cell triggering paraview installation on Colab #1481

Merged
merged 10 commits into from
Dec 26, 2024

Conversation

AgnieszkaZaba
Copy link
Collaborator

Addresses #1467

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (5a49cb0) to head (9b49e79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1481   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         376      376           
  Lines        9266     9266           
=======================================
  Hits         7897     7897           
  Misses       1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo
Copy link
Member

slayoo commented Dec 22, 2024

Thank you @AgnieszkaZaba!

Let me suggest to:

  • move this .ipynb file to the _HOWTOS folder (it does not reproduce results from the paper, Paraview was not used in the paper, while it does serve the purpose of explaining how to use Paraview to visualise results from 2D prescribed-flow simulations)
  • annotate the ln -s ... workaround explaining that it aims to solve a problem with the Ubuntu package (especially that after Ubuntu upgrades on Colab, the problem will likely cease to exist, and the ln -s ... line will trigger an error, while the Paraview installation ill be fine)

@AgnieszkaZaba
Copy link
Collaborator Author

Thanks @slayoo!
Definitely it belongs to howtos. I will move it.
Don't know yet what to do with the second point.

And I'll will look up ipyparaview

@slayoo
Copy link
Member

slayoo commented Dec 23, 2024

Don't know yet what to do with the second point.

We could:

! if [ ! -f /usr/lib/libpdal_base.so.13 ]; then ln -s /usr/lib/libpdal_base.so.15 /usr/lib/libpdal_base.so.13; fi

And I'll will look up ipyparaview

Thanks! (but let's do it independently of this PR)

@AgnieszkaZaba
Copy link
Collaborator Author

* [ ]  add a comment with links to https://discourse.paraview.org/t/paraview-error-while-loading-shared-libraries-libpdal-base-so-13-cannot-open-shared-object-file/14000 and https://discourse.paraview.org/t/paraview-error-while-loading-shared-libraries-libpdal-base-so-13-cannot-open-shared-object-file/14000

I will add this link as a second one.

@slayoo
Copy link
Member

slayoo commented Dec 24, 2024

there is a typo, here's the url: qgis/QGIS#52433 (comment)

@AgnieszkaZaba
Copy link
Collaborator Author

Thanks for noticing!
Do you know why the second line with ldconfig getting me warnings? And it looks like it is not needed.

@AgnieszkaZaba AgnieszkaZaba self-assigned this Dec 24, 2024
@AgnieszkaZaba AgnieszkaZaba mentioned this pull request Dec 24, 2024
5 tasks
@slayoo slayoo changed the title add paraview installation on Colab move paraview_hello_world notebook from examples to HOWTOs; add cell triggering paraview installation on Colab Dec 26, 2024
@slayoo
Copy link
Member

slayoo commented Dec 26, 2024

Thank you!

@slayoo slayoo added this pull request to the merge queue Dec 26, 2024
Merged via the queue into open-atmos:main with commit 91278ac Dec 26, 2024
186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants