Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibliography in documentation (data in .json file, scripts checking consistency with DOI mentions in the codebase) #1483

Merged
merged 11 commits into from
Jan 2, 2025

Conversation

pawelmagnu
Copy link
Collaborator

A couple of questions regarding this PR to @slayoo :

  • Should the test to determine whether all dois referenced in code are in the JSON file be part of PySDM, or should we move it to a DevOps test?
  • Should the bib table have more columns than the title, doi, and references to places in the code?
  • Is the phrase "cross-reference" a good way to refer to places in code where each doi is mentioned?
  • After this PR, the main .HTML file will have 8 subsections (intro, links, installation, dependencies etc.) Should we bring back the navigation for easier access and discovery of each section?

Also, before closing this PR we need to fill in the missing values(title, year, authors, etc.) in the JSON file, or remove these fields from JSON altogether.

@slayoo
Copy link
Member

slayoo commented Jan 1, 2025

Thanks @pawelmagnu !

* Should the test to determine whether all dois referenced in code are in the JSON file be part of PySDM, or should we move it to a DevOps test?

Let me try to integrate it into the docs.py script, and then (in a separate PR), we can move out the script to some common location and is it from both PySDM and PyMPDATA

@slayoo
Copy link
Member

slayoo commented Jan 1, 2025

* Should the bib table have more columns than the title, doi, and references to places in the code?

I've added a "label" field which is used for sorting

* Is the phrase "cross-reference" a good way to refer to places in code where each doi is mentioned?

yes! (I've also added a single-sentence paragraph explaining what is in the reference list)

* After this PR, the main .HTML file will have 8 subsections (intro, links, installation, dependencies etc.) Should we bring back the navigation for easier access and discovery of each section?

indeed, worth considering to bring it back

Also, before closing this PR we need to fill in the missing values(title, year, authors, etc.) in the JSON file, or remove these fields from JSON altogether.

done.

@slayoo slayoo changed the title Bibliography generation from .json Bibliography in documentation (data in .json file, scripts checking consistency with DOI mentions in the codebase) Jan 1, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (91278ac) to head (c1eef6a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         376      376           
  Lines        9266     9266           
=======================================
  Hits         7897     7897           
  Misses       1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo slayoo merged commit a16f63f into open-atmos:main Jan 2, 2025
186 checks passed
@slayoo slayoo mentioned this pull request Jan 2, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants