Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add installation of paraview to run on colab #1486

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

AgnieszkaZaba
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (a16f63f) to head (57117fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1486   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         376      376           
  Lines        9266     9266           
=======================================
  Hits         7897     7897           
  Misses       1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slayoo
Copy link
Member

slayoo commented Jan 5, 2025

@AgnieszkaZaba, is the following cell:

if 'google.colab' in sys.modules:
    !apt-get -qq install python3-paraview
    
    # Workaround for a bug in Ubuntu package described here
    # (https://discourse.paraview.org/t/paraview-error-while-loading-shared-libraries-libpdal-base-so-13-cannot-open-shared-object-file/14000);
    # with solution taken from that comment: https://github.com/qgis/QGIS/issues/52433#issuecomment-1792285094.
    ! if [ ! -f /usr/lib/libpdal_base.so.13 ]; then ln -s /usr/lib/libpdal_base.so.15 /usr/lib/libpdal_base.so.13; fi 

left intentionally (for mybinder.org?) or should we remove it?

@AgnieszkaZaba
Copy link
Collaborator Author

@AgnieszkaZaba, is the following cell:

if 'google.colab' in sys.modules:
    !apt-get -qq install python3-paraview
    
    # Workaround for a bug in Ubuntu package described here
    # (https://discourse.paraview.org/t/paraview-error-while-loading-shared-libraries-libpdal-base-so-13-cannot-open-shared-object-file/14000);
    # with solution taken from that comment: https://github.com/qgis/QGIS/issues/52433#issuecomment-1792285094.
    ! if [ ! -f /usr/lib/libpdal_base.so.13 ]; then ln -s /usr/lib/libpdal_base.so.15 /usr/lib/libpdal_base.so.13; fi 

left intentionally (for mybinder.org?) or should we remove it?

I forgot to remove it.
Since you mention mybinder I checked it and there is a problem with pvpython path. I created an issue #1490 for that and marked it as good first issue.

@AgnieszkaZaba AgnieszkaZaba added this pull request to the merge queue Jan 7, 2025
Merged via the queue into open-atmos:main with commit 824a94d Jan 7, 2025
189 checks passed
@AgnieszkaZaba AgnieszkaZaba deleted the paraview branch January 7, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants