Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hall kernel #1526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hall kernel #1526

wants to merge 1 commit into from

Conversation

jbarr444
Copy link

@jbarr444 jbarr444 commented Mar 8, 2025

Added a collision kernel which interpolates the table from Hall 1980.

@slayoo
Copy link
Member

slayoo commented Mar 9, 2025

@jbarr444, the key prerequisite for any PR is a unit test.
Here, we have the table from the paper that can serve as a source for expected values.
We use the pytest framework for unit testing, here's an example tutorial: https://betterstack.com/community/guides/testing/pytest-guide/
In short, we need a function (named test_... to be discoverable by pytest) that includes an arrange-act-assert logic, in which a minimal setup (the "arrange" part) to use the new code would be executed (the "act" part), and the results obtained by the newly introduced unit would be checked against dome reference values (the "assert" part).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants