Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notebook_vars utility with example notebook and unit test depicting how it can be ised to construct a pytest fixture with the notebook state after execution #39

Merged
merged 11 commits into from
Jan 20, 2025
Merged

add notebook_vars utility with example notebook and unit test depicting how it can be ised to construct a pytest fixture with the notebook state after execution #39

merged 11 commits into from
Jan 20, 2025

Conversation

AgnieszkaZaba
Copy link
Collaborator

No description provided.

@slayoo
Copy link
Member

slayoo commented Jan 20, 2025

we could also create a quick short test within the tests folder that would use the new notebook_vars to read variables from a notebook and do some basic asserts

@AgnieszkaZaba
Copy link
Collaborator Author

we could also create a quick short test within the tests folder that would use the new notebook_vars to read variables from a notebook and do some basic asserts

@slayoo please review if this is correct way. Should we just create a test for existing notebook (with renaming)? Or add new notebook just for testing notebook_vars?

@slayoo slayoo changed the title add notebook_vars to jupyter-utils add notebook_vars utility with example notebook and unit test depicting how it can be ised to construct a pytest fixture with the notebook state after execution Jan 20, 2025
@slayoo slayoo added this pull request to the merge queue Jan 20, 2025
@slayoo
Copy link
Member

slayoo commented Jan 20, 2025

Thank you @AgnieszkaZaba !

Merged via the queue into open-atmos:main with commit a04d4e6 Jan 20, 2025
4 checks passed
@AgnieszkaZaba AgnieszkaZaba deleted the notebook-vars branch January 20, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slayoo slayoo slayoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgnieszkaZaba @slayoo