Update Dependencies and Make Generic for Any City #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove all migrations - Migrations were using grunt-mongo-migrations package, which depends on the now-deprecated fibers package. Migrations were specific to Chicago anyway * Upgrade all packages using npm-check-updates * Remove requests package - Deprecated. Just using node's http library now * Handle changes in mongoose package (use promises instead of callbacks)
* Mapbox API key seems stale. Hoping to migrate to all open mapping data to remove need for API keys
* Nominatim is free and uses OpenStreetMap data. Their use policy says as long as you have < 1 req/s you can use their public API. If usage were high it can be self-hosted. This gets rid of dependency on Google geocode API
* Commit 6ff1def attempted to upgrade the node and mongoose version, but left some issues behind * Mongoose library now uses promises, not callbacks. You must call .then() for actions like .save() to actually do anything
* Dependency on mailchimp not desired here. Other forks could add an email list if they want
* Begin to make the Chicago portions of the project generic, to allow custom messages and configuration
* In an effort to make this generic for any city, move all references to 'chicago' to configurations, and move all static information to config folder * TODO: Decide how to handle wards - consider reworking with a more generic name, such as "district"? Need to remove Chicago references from wards page
* Wards are a nice feature for Chicago, but Chicago has uniquely powerful aldermen. Also, the scripting required to maintain the ward functionality is a bit tedious
* `npm test` does hang now, but at least the tests pass
* Now the map will load in the right spot depending on config
* If multiple address matches were found, the wrong property names were being used for lat/lon and full address name * I was filtering out things marked as 'place' on OpenStreetMap, which apparently includes some apartment buildings. For now, use 'place' and 'building'
- Node doesn't have a DockerHub image for darwin, so just don't build for it for now
Update to new url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest versions of dependencies, and makes this project usable for cities besides Chicago
configfolderSee #182