-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set failureThreshold to 3 for improved stability #214
Set failureThreshold to 3 for improved stability #214
Conversation
Signed-off-by: Rokibul Hasan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 15.36% 15.36%
=======================================
Files 32 32
Lines 2011 2011
=======================================
Hits 309 309
Misses 1680 1680
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, RokibulHasan7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ea838c0
into
open-cluster-management-io:main
This reverts commit ea838c0.
…r-management-io#214)" This reverts commit ea838c0. Signed-off-by: xuezhaojun <[email protected]>
@RokibulHasan7 The error log reflects the connect error to the proxy-server, change |
@qiujian16 @RokibulHasan7 Suggest revert by: #216 |
After discussion, we found it's not a bug, the root cause is the default entrypoint type is |
This reverts commit ea838c0. Signed-off-by: xuezhaojun <[email protected]>
addon-agent restarts due to a connection error:
"cannot connect once" err="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp 127.0.0.1:8091: connect: connection refused\""