Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set failureThreshold to 3 for improved stability #214

Conversation

RokibulHasan7
Copy link
Member

addon-agent restarts due to a connection error: "cannot connect once" err="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp 127.0.0.1:8091: connect: connection refused\""

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.36%. Comparing base (870ab80) to head (9e43887).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   15.36%   15.36%           
=======================================
  Files          32       32           
  Lines        2011     2011           
=======================================
  Hits          309      309           
  Misses       1680     1680           
  Partials       22       22           
Flag Coverage Δ
unit 15.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, RokibulHasan7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ea838c0 into open-cluster-management-io:main Nov 4, 2024
9 checks passed
xuezhaojun added a commit that referenced this pull request Nov 4, 2024
xuezhaojun added a commit to xuezhaojun/cluster-proxy that referenced this pull request Nov 4, 2024
@xuezhaojun
Copy link
Member

xuezhaojun commented Nov 4, 2024

@RokibulHasan7 The error log reflects the connect error to the proxy-server, change failureThreshould doesn't help in this case.

@xuezhaojun
Copy link
Member

@qiujian16 @RokibulHasan7 Suggest revert by: #216

@xuezhaojun
Copy link
Member

After discussion, we found it's not a bug, the root cause is the default entrypoint type is PortForward which is not suite to k3s in a VM case.

xuezhaojun added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants