Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix the wrong apiserver endpoint in hosted mode #390

Conversation

elgnay
Copy link
Contributor

@elgnay elgnay commented Nov 7, 2023

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from qiujian16 and ycyaoxdu November 7, 2023 07:43
@elgnay
Copy link
Contributor Author

elgnay commented Nov 7, 2023

/hold

@elgnay elgnay force-pushed the fix-wrong-endpoint branch from 46c50b3 to b6c8749 Compare November 7, 2023 09:31
@elgnay elgnay closed this Nov 7, 2023
@elgnay elgnay reopened this Nov 7, 2023
@elgnay elgnay closed this Nov 7, 2023
@elgnay elgnay reopened this Nov 7, 2023
@elgnay elgnay closed this Nov 8, 2023
@elgnay elgnay reopened this Nov 8, 2023
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@elgnay
Copy link
Contributor Author

elgnay commented Nov 8, 2023

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 205e896 into open-cluster-management-io:main Nov 8, 2023
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants