🌱 Update e2e for upgrade cluster manager #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
upgrade-e2e
branch
from
d9ccbbd to
2f0636c
Compare
zhujian7
reviewed
Nov 10, 2023
|
|
||
| err = e2e.Clusteradm().Upgrade( | ||
| "klusterlet", | ||
| "clustermanager", |
There was a problem hiding this comment.
so we only need to test upgrading the clustermanager, not klusterlet, right?
There was a problem hiding this comment.
we need to, will add another test for klusterlet
qiujian16
force-pushed
the
upgrade-e2e
branch
11 times, most recently
from
7545bc1 to
6e09b28
Compare
Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
upgrade-e2e
branch
9 times, most recently
from
df36d1d to
31834c7
Compare
Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
upgrade-e2e
branch
from
31834c7 to
bb08b28
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 4d7d077
into
open-cluster-management-io:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #387