Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ clusteradm join support resource-qos-class parameter #398

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

haowells
Copy link
Contributor

@haowells haowells commented Dec 2, 2023

Summary

  1. Klusterlet cr add new flag UseBestEffortResource which allow user use besteffort setting for deployment agent, registration, work etc
    related PR ✨ klusterlet cr add flag to use best effort resources ocm#317
  2. Add bool flag "createNamespace" to allow use existing open-cluster-management-* ns. reason behind it because our k8s setup have bunch of customized ns label/annotations that is different from default

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from itdove and yue9944882 December 2, 2023 13:16
@haowells
Copy link
Contributor Author

haowells commented Dec 4, 2023

/assign @qiujian16 @haoqing0110

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you would need to update the api library in go.mod and also the manifests under join cmd.

@qiujian16
Copy link
Member

there is an error during tests

Error: error when creating "local": Klusterlet.operator.open-cluster-management.io "klusterlet" is invalid: spec.resourceRequirement.type: Unsupported value: "default": supported values: "Default", "BestEffort"

@haowells
Copy link
Contributor Author

haowells commented Dec 5, 2023

I think you would need to update the api library in go.mod and also the manifests under join cmd.

@qiujian16 update api to latest commit and push new commit
go get open-cluster-management.io/api@97a8a92a7f30a0aaf123b8a7a9fa94859baea15b

@haowells
Copy link
Contributor Author

haowells commented Dec 5, 2023

there is an error during tests

Error: error when creating "local": Klusterlet.operator.open-cluster-management.io "klusterlet" is invalid: spec.resourceRequirement.type: Unsupported value: "default": supported values: "Default", "BestEffort"

address in this commit daea105

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2023
@haoqing0110
Copy link
Member

/lgtm

@qiujian16
Copy link
Member

/approve

Copy link

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haowells, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b2767b6 into open-cluster-management-io:main Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants