-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ clusteradm join support resource-qos-class parameter #398
✨ clusteradm join support resource-qos-class parameter #398
Conversation
Signed-off-by: haolin <[email protected]>
Signed-off-by: haolin <[email protected]>
/assign @qiujian16 @haoqing0110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you would need to update the api library in go.mod and also the manifests under join cmd.
Signed-off-by: haolin <[email protected]>
Signed-off-by: haolin <[email protected]>
there is an error during tests
|
Signed-off-by: haolin <[email protected]>
Signed-off-by: haolin <[email protected]>
@qiujian16 update api to latest commit and push new commit |
address in this commit daea105 |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haowells, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b2767b6
into
open-cluster-management-io:main
Summary
related PR ✨ klusterlet cr add flag to use best effort resources ocm#317
Related issue(s)
Fixes #