🐛 Fix single-use dialer already dialed issue

[RokibulHasan7]

Summary

Before:

$ clusteradm proxy health
I1102 11:57:52.678047   38144 portforward.go:154] Forwarding to pod cluster-proxy-696b948dff-bmlhx
E1102 11:57:53.647755   38144 exec.go:278] Failed requesting /healthz endpoint for cluster default: No agent available
I1102 11:57:53.754295   38144 portforward.go:249] Connection closed due to error stream closed
E1102 11:57:53.755129   38144 exec.go:278] Failed requesting /healthz endpoint for cluster global: single-use dialer already dialed
E1102 11:57:53.858835   38144 exec.go:278] Failed requesting /healthz endpoint for cluster spoke2: single-use dialer already dialed

After:

clusteradm proxy health
I1105 13:49:17.028443   16533 portforward.go:154] Forwarding to pod cluster-proxy-696b948dff-zqfw8
I1105 13:49:18.541635   16533 portforward.go:154] Forwarding to pod cluster-proxy-696b948dff-zqfw8
CLUSTER NAME    INSTALLED    AVAILABLE    PROBED HEALTH    LATENCY
rakib           True         True         True             598.983698ms
spoke1          True         True         False            <none>

Related issue(s)

Fixes #

[zhujian7]

/cc @xuezhaojun could you please take a look at this PR? thx

[xuezhaojun]

@RokibulHasan7 Is this also the k3s environment?

[RokibulHasan7]

@RokibulHasan7 Is this also the k3s environment?

yes

[xuezhaojun]

@RokibulHasan7
It seems CreateSingleUseGrpcTunnel is deprecated, can we try use CreateSingleUseGrpcTunnelWithContext instead?

// Deprecated 2022-06-07: use CreateSingleUseGrpcTunnelWithContext
func CreateSingleUseGrpcTunnel(tunnelCtx context.Context, address string, opts ...grpc.DialOption) (Tunnel, error) {
	return CreateSingleUseGrpcTunnelWithContext(context.TODO(), tunnelCtx, address, opts...)
}

btw, is the fix verified in your env? Can we have command result of fixed version also pasted?

[RokibulHasan7]

@RokibulHasan7 It seems CreateSingleUseGrpcTunnel is deprecated, can we try use CreateSingleUseGrpcTunnelWithContext instead?

// Deprecated 2022-06-07: use CreateSingleUseGrpcTunnelWithContext
func CreateSingleUseGrpcTunnel(tunnelCtx context.Context, address string, opts ...grpc.DialOption) (Tunnel, error) {
	return CreateSingleUseGrpcTunnelWithContext(context.TODO(), tunnelCtx, address, opts...)
}

btw, is the fix verified in your env? Can we have command result of fixed version also pasted?

working in my env. Description updated.

[xuezhaojun]

/lgtm

[xuezhaojun]

@zhujian7 The fix looks good to me, I think we can approve it.

[zhujian7]

/cc @qiujian16

[qiujian16]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, RokibulHasan7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment