proposal change for clusterset api #48
Conversation
|
/cc @qiujian16 @elgnay |
|
/lgtm |
| // ManagedClusterSelector represents a selector of ManagedClusters | ||
| type ManagedClusterSelector struct { | ||
| // SelectorType could only be "LegacyClusterSetLabel" now, will support more SelectorType later | ||
| // "LegacyClusterSetLabel" means to use label "cluster.open-cluster-management.io/clusterset:<ManagedClusterSet Name>"" to select target clusters. |
There was a problem hiding this comment.
I think we should also add labelSelector
| ``` | ||
|
|
||
| - `LabelSelector` will not be included |
There was a problem hiding this comment.
let's keep the labelSelector since it should done in this release
| b. `submariner-addon` uses managedClusterSet group clusters based on the network. And in different managedClusterSet, the clusters should be exclusive. So it should only watch the following managedClusterSet: | ||
| - `spec.ClusterSelector.SelectorType` is `LegacyClusterSetLabel` | ||
|
|
||
| c. `placement` using new `ClusterSelector` to select target clusters. | ||
|
|
||
| 3. [Implement in OCM 0.8.0] Update full managedClusterSet api and RBAC | ||
| - Include `LabelSelector` |
There was a problem hiding this comment.
I think exclusiveKey is not necessary?
There was a problem hiding this comment.
I think exclusiveKey is not necessary?
I am not really understand what you mean, Do you mean we should remove the ExclusiveLabel in selectorType ?
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: ldpliu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ldpliu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ldpliu [email protected]