Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Deprecate managedserviceaccount v1alpha1 #92

Merged
merged 2 commits into from
Jan 3, 2024
Merged

🌱 Deprecate managedserviceaccount v1alpha1 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c7ac6f
Deprecate managedserviceaccount v1alpha1
zhujian7 Jan 2, 2024
1eefef3
Add deprecation warning
zhujian7 Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/authentication/v1alpha1/managedserviceaccount_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func init() {

//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:storageversion
//+kubebuilder:deprecatedversion:warning="authentication.open-cluster-management.io/v1alpha1 ManagedServiceAccount is deprecated; use authentication.open-cluster-management.io/v1beta1 ManagedServiceAccount; version v1alpha1 will be removed in the next release"

// +genclient
// ManagedServiceAccount is the Schema for the managedserviceaccounts API
Expand Down
1 change: 1 addition & 0 deletions apis/authentication/v1beta1/managedserviceaccount_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func init() {

//+kubebuilder:object:root=true
//+kubebuilder:subresource:status
//+kubebuilder:storageversion

// +genclient
// ManagedServiceAccount is the Schema for the managedserviceaccounts API
Expand Down
10 changes: 7 additions & 3 deletions ...serviceaccount/crds/authentication.open-cluster-management.io_managedserviceaccounts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ spec:
singular: managedserviceaccount
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: authentication.open-cluster-management.io/v1alpha1 ManagedServiceAccount
is deprecated; use authentication.open-cluster-management.io/v1beta1 ManagedServiceAccount;
version v1alpha1 will be removed in the next release
name: v1alpha1
schema:
openAPIV3Schema:
description: ManagedServiceAccount is the Schema for the managedserviceaccounts
Expand Down Expand Up @@ -167,7 +171,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- name: v1beta1
Expand Down Expand Up @@ -321,7 +325,7 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
status:
Expand Down
10 changes: 7 additions & 3 deletions config/crd/bases/authentication.open-cluster-management.io_managedserviceaccounts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ spec:
singular: managedserviceaccount
scope: Namespaced
versions:
- name: v1alpha1
- deprecated: true
deprecationWarning: authentication.open-cluster-management.io/v1alpha1 ManagedServiceAccount
is deprecated; use authentication.open-cluster-management.io/v1beta1 ManagedServiceAccount;
version v1alpha1 will be removed in the next release
name: v1alpha1
schema:
openAPIV3Schema:
description: ManagedServiceAccount is the Schema for the managedserviceaccounts
Expand Down Expand Up @@ -167,7 +171,7 @@ spec:
type: object
type: object
served: true
storage: true
storage: false
subresources:
status: {}
- name: v1beta1
Expand Down Expand Up @@ -321,7 +325,7 @@ spec:
type: object
type: object
served: true
storage: false
storage: true
subresources:
status: {}
status:
Expand Down
Loading