Apply suggestions from code review

Co-authored-by: James McKinney <[email protected]>
open-contracting · Nov 9, 2023 · 78a1836 · 78a1836
1 parent 462d9b3
commit 78a1836
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/exporter/views.py b/exporter/views.py
@@ -20,9 +20,9 @@ def download_export(request, id):
 
     active_job = collection.job.filter(active=True).first()
     if not active_job:
-        return HttpResponseNotFound("No active job was found for this collection")
+        return HttpResponseNotFound("This OCDS dataset is not available for download")
 
-    export = Export(active_job.id, basename=f"{name}")
+    export = Export(active_job.id, basename=name)
     if export.status != TaskStatus.COMPLETED:
         return HttpResponseNotFound("File not found")
 

diff --git a/tests/exporter/test_views.py b/tests/exporter/test_views.py
@@ -25,14 +25,14 @@ def test_download_export_invalid_suffix(self):
             response = Client().get("/publication/2/download?name=invalid")
 
         self.assertEqual(response.status_code, 400)
-        self.assertEqual(response.content, b"Suffix not recognized")
+        self.assertEqual(response.content, b"The name query string parameter is invalid")
 
     def test_download_export_empty_parameter(self):
         with self.assertNumQueries(0):
             response = Client().get("/publication/2/download?name=")
 
         self.assertEqual(response.status_code, 400)
-        self.assertEqual(response.content, b"Suffix not recognized")
+        self.assertEqual(response.content, b"The name query string parameter is invalid")
 
     def test_download_export_waiting(self):
         with self.assertNumQueries(1):