Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishers.html: add guidance on URL directory paths #82

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Apr 3, 2024

@odscjen
Copy link
Contributor Author

odscjen commented Apr 3, 2024

The test failure is because there's not a translation of the new sentences. I think it makes sense to do once we've agreed on this change to the English version.

@coveralls
Copy link

coveralls commented Apr 3, 2024

Pull Request Test Coverage Report for Build 8556024591

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.991%

Totals Coverage Status
Change from base Build 8302702690: 0.0%
Covered Lines: 431
Relevant Lines: 449

💛 - Coveralls

@odscjen
Copy link
Contributor Author

odscjen commented Apr 4, 2024

@yolile please could you deal with the translation of this PR?

@yolile
Copy link
Member

yolile commented Apr 4, 2024

@odscjen Sure thing, have you pushed the text to transifex already or should I?

@odscjen
Copy link
Contributor Author

odscjen commented Apr 4, 2024

thanks, I haven't pushed to transifex so if you could do that too that would be great!

@yolile
Copy link
Member

yolile commented Apr 4, 2024

Done!

@odscjen
Copy link
Contributor Author

odscjen commented Apr 4, 2024

thank you @yolile! @jpmckinney are we ok to merge this now?

@jpmckinney jpmckinney merged commit 579e934 into main Apr 4, 2024
6 checks passed
@jpmckinney jpmckinney deleted the 1571_normative_guidance_path branch April 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants