Implement asynchronous publisher #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isherProcessAPI2 to 500, now that KingfisherProcessAPI is removed.
…bbitMQ restarts. test: Simplify test_spider_closed to test_spider_closed_error, as the success case is covered by test_spider_opened. test: Remove "raises" logic from test_item_scraped, as this works only for a blocking basic_publish call. Revert "feat: Use the asyncio reactor, to be able to use yapw async clients" 1884445 Revert "test: Set the reactor correctly" 442bbf1 Note: kingfisher_process_items_sent_rabbit and kingfisher_process_items_failed_rabbit stats are no longer tracked, as publishing is not expected to error.
…twisted.internet.error.ReactorAlreadyRunning"
…tension waits for the new connection to be established
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1033