fix: use new endpoints for mexico_nuevo_leon_* #1122
Conversation
| # PeriodicSpider | ||
| date_format = 'year' | ||
| pattern = 'https://smpu.nl.gob.mx/siasi_ws/api/ocds/ListarProduccionXAnio?anio=%5B%7B"value":"{0}"%7D%5D' | ||
| formatter = staticmethod(parameters('anio')) | ||
| default_from_date = '2013' |
There was a problem hiding this comment.
date_format and default_from_date go in a # BaseSpider section: https://kingfisher-collect.readthedocs.io/en/latest/contributing/index.html
|
|
||
|
|
||
| class MexicoNuevoLeonReleases(CompressedFileSpider): | ||
| class MexicoNuevoLeonReleases(MexicoNuevoLeonRecords): |
There was a problem hiding this comment.
Do we want this spider? I don't think we typically use a records endpoint to create a releases spider.
There was a problem hiding this comment.
I guess we want it as it would be the only way to get the original releases, as the record contains compiled and linked releases only. I could create a base class instead of inheriting from Records though
There was a problem hiding this comment.
Aha, makes sense. Please create a base class, since in future we might not want changes to the records spider to cause changes in the releases spider.
closes #1100