Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance_and_extensions.md: add normative guidance about extension… #1682

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Mar 29, 2024

… paths

partially addresses #1571

The other page in this repo that references Extensions is https://standard.open-contracting.org/latest/en/guidance/map/extensions/ but all it says is of relevant here is "You can find the extension template on GitHub. It contains guidance on creating an extension." and while the guidance will be moved there will still be a link to it from the extension template so I don't think we need to alter this sentence.

This PR does not close the linked issue as it still requires updating the extension_explorer repo

@jpmckinney
Copy link
Member

I added the extension template's two issues to the OCDS 1.2 project, so I think this would now close #1571, correct?

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few other unrelated commits, instead of making an entire new PR.

@odscjen
Copy link
Contributor Author

odscjen commented Apr 9, 2024

those extra commits all look good, I'll go ahead and merge this

@odscjen odscjen merged commit d68e4fb into 1.2-dev Apr 9, 2024
10 checks passed
@odscjen odscjen deleted the 1571_extension_normative_guidance branch April 9, 2024 09:35
@odscjen odscjen restored the 1571_extension_normative_guidance branch April 9, 2024 09:40
@odscjen odscjen deleted the 1571_extension_normative_guidance branch April 9, 2024 09:44
@odscjen
Copy link
Contributor Author

odscjen commented Apr 9, 2024

@jpmckinney hmm, despite the tests passing in the PR when I merged it's created a lint error, I'm not sure how to fix that!

@jpmckinney
Copy link
Member

Don’t worry, it’s a false positive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants