TravelQ Destination Fields Revamp #1532
Conversation
- Added extra help text capability to PD webforms.
- Added extra destination fields. - Added language requirement triggers. - Added excel error formulae for language requirements. - Started working on the PSQL regexp_match for destination format.
- Made `destination_clean_error` function. - Continued excel formulaes for destination fields.
- Added multiple destinations clean error function. - Heavily improved the regex macthes for destination formats.
- PSQL type cast for regexp_match.
- Continued excel formulae.
- New pytest for travelq destination formats.
- Upgrade postgres version for tests. - Added more travelq destination test conditions.
- Added change log file.
|
Have to fix the regex for multi-destination field. Trying to figure out the capture grouping, not sure if it needs to be some dynamic grouping, or if we can do some really scary looping in PSQL |
- Fixed up the multi-destination trigger function with `regexp_split_to_array`.
- `United States of America` -> `USA`.
- Changes to travelq.
- `United States of America` -> `USA` in psql function.
|
For both travelq and hospitalityq is it better to pair the 1,2,3,other English and french fields instead of having them separated? Just a general usability question, not sure the best person to ask. |
|
Yeah it probably is a lot better to group them that way, will do that. |
- Field order for travelq destination fields.
- Use local countries file instead of an API.
- Removed `destination_3` fields. - Fix typo in destination_2 french field label.
- Allow province/state formatting.
- Updated destination trigger methods to handle blank destinations.
|
@wardi okay this should be good for a re-review now. And since we are supporting even more optional formatting here, I doubt we would be able to do a nice and reliable Excel formula. So I think we can just exclude that from these fields unless if you really want to bash your head against it haha |
- New text for destination fields.
- Error depth for multi-destination fields.
- Translated revised TravelQ destination fields.
This will be one of the first time we stop doing parity between PSQL and Excel. Business requirements are reaching a point in which we will just have to stop doing crazy things in Excel.