Skip to content

Commit

Permalink
feat: throw IllegalStateError upon illegal state (#3)
Browse files Browse the repository at this point in the history
  • Loading branch information
kettanaito authored Oct 20, 2022
1 parent 1b60c0f commit 9819dcd
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 9 deletions.
14 changes: 10 additions & 4 deletions src/DeferredPromise.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { IllegalStateError } from "./IllegalStateError";

export type DeferredPromiseState = "pending" | "resolved" | "rejected";

export type ResolveFunction<Data extends any, Result = void> = (
data: Data
) => Result | PromiseLike<Result>;

export type RejectFunction<Result = void> = (
reason?: unknown
) => Result | PromiseLike<Result>;
Expand Down Expand Up @@ -31,8 +35,9 @@ export class DeferredPromise<Data extends any = void> {
this.promise = new Promise<Data>((resolve, reject) => {
this.resolve = (data) => {
if (this.state !== "pending") {
throw new TypeError(
`Cannot resolve a DeferredPromise: illegal state ("${this.state}")`
throw new IllegalStateError(
"Cannot resolve a DeferredPromise: illegal state",
this.state
);
}

Expand All @@ -43,8 +48,9 @@ export class DeferredPromise<Data extends any = void> {

this.reject = (reason) => {
if (this.state !== "pending") {
throw new TypeError(
`Cannot reject a DeferredPromise: illegal state ("${this.state}")`
throw new IllegalStateError(
"Cannot reject a DeferredPromise: illegal state",
this.state
);
}

Expand Down
7 changes: 7 additions & 0 deletions src/IllegalStateError.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { type DeferredPromiseState } from "./DeferredPromise";

export class IllegalStateError extends Error {
constructor(message: string, public readonly state: DeferredPromiseState) {
super(message);
}
}
3 changes: 2 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from './DeferredPromise'
export * from "./DeferredPromise";
export * from "./IllegalStateError";
11 changes: 7 additions & 4 deletions test/DeferredPromise.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { DeferredPromise } from "../src";
import { IllegalStateError } from "../src/IllegalStateError";

describe("Promise-compliance", () => {
it('can be listened to with ".then()"', (done) => {
Expand Down Expand Up @@ -105,8 +106,9 @@ describe("resolve()", () => {
promise.resolve(123);

expect(() => promise.resolve(456)).toThrow(
new TypeError(
'Cannot resolve a DeferredPromise: illegal state ("resolved")'
new IllegalStateError(
"Cannot resolve a DeferredPromise: illegal state",
"resolved"
)
);
});
Expand All @@ -117,8 +119,9 @@ describe("resolve()", () => {
promise.reject();

expect(() => promise.resolve(123)).toThrow(
new TypeError(
'Cannot resolve a DeferredPromise: illegal state ("rejected")'
new IllegalStateError(
"Cannot resolve a DeferredPromise: illegal state",
"rejected"
)
);
});
Expand Down

0 comments on commit 9819dcd

Please sign in to comment.