Merge pull request #34 from open-dynamic-robot-initiative/fkloss/pybi…

…nd11

find pybind11 before ament_cmake to fix error on Ubuntu 22.04

.github/workflows/pr_todo_checks.yml

@@ -7,10 +7,9 @@ jobs:
     name: New FIXMEs
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - run: git fetch origin ${GITHUB_BASE_REF}
+    - uses: actions/checkout@v3
     - name: Check for FIXMEs
-      uses: luator/github_action_check_new_todos@v1.0.0
+      uses: luator/github_action_check_new_todos@v2
       with:
           label: FIXME
           base_ref: origin/${{ github.base_ref }}
@@ -19,10 +18,9 @@ jobs:
     name: New TODOs
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - run: git fetch origin ${GITHUB_BASE_REF}
+    - uses: actions/checkout@v3
     - name: Check for TODOs
-      uses: luator/github_action_check_new_todos@v1.0.0
+      uses: luator/github_action_check_new_todos@v2
       with:
           label: TODO
           base_ref: origin/${{ github.base_ref }}

CHANGELOG.md

@@ -11,6 +11,10 @@
 ### Removed
 - Obsolete script `verify_calibration.py`
 
+### Fixed
+- pybind11 build error on Ubuntu 22.04
+
+
 ## [1.0.0] - 2022-06-28
 ### Added
 - Executable `pylon_list_cameras` which lists all detected Pylon cameras.

CMakeLists.txt

@@ -8,10 +8,16 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR}/cmake)
 
+# pybind11 needs to be first, otherwise other packages which also search for
+# Python can cause an 'Unknown CMake command "python3_add_library"' error.
+# Probably related to how Python is found, see
+# https://github.com/pybind/pybind11/issues/3996
+find_package(pybind11 REQUIRED)
+#message(FATAL "Python_FOUND = ${Python_FOUND}, Python3_FOUND = ${Python3_FOUND}")
+
 find_package(ament_cmake REQUIRED)
 find_package(ament_index_cpp REQUIRED)
 find_package(mpi_cmake_modules REQUIRED)
-find_package(pybind11 REQUIRED)
 find_package(pybind11_opencv REQUIRED)
 find_package(cereal REQUIRED)
 find_package(robot_interfaces REQUIRED)