Some minor changes regarding sensor info #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on answers to [this SO question](https://stackoverflow.com/q/39932391), - `virtual` should only should be used on the first appearance of a method (i.e. in the base class), and - all child classes should use `override` (or `final` if appropriate).
If the `CalibratedCamera` is used, set also the distortion_coefficients in sensor_info_. When using `Camera`, there is no distortion, so just leaving them at zero (which they are initialised to by default) should be correct.
So it can conveniently be accessed in back-end code (or when just using the driver class directly).
Add function `print_tricamera_sensor_info` to the utils module. It pretty-prints the data from TriCameraInfo in a table. Add this here, so we don't have to duplicate the code in all the scripts where we want to print this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several minor additions/fixes concerning the sensor info. See individual commits for details.