Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use new Statsig Api to return default value when flag is not defined #177

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: Use new Statsig Api to return default value when flag is not defined #177

merged 1 commit into from
Apr 16, 2024

Conversation

jenshenneberg
Copy link
Contributor

This PR

  • updates the Statsig provider so it now returns the default value when a flag is not defined

Notes

Fix was made possible after the Statsig added the new GetFeatureGate API here

@jenshenneberg jenshenneberg marked this pull request as ready for review April 10, 2024 03:01
@jenshenneberg jenshenneberg requested a review from a team as a code owner April 10, 2024 03:01
@jenshenneberg jenshenneberg removed their assignment Apr 10, 2024
askpt
askpt approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beeme1mr beeme1mr merged commit 5efc8a6 into open-feature:main Apr 16, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askpt askpt askpt approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshenneberg @beeme1mr @askpt