chore: additional unit tests for flagd provider #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
beeme1mr
approved these changes
May 14, 2024
toddbaert
reviewed
May 15, 2024
| @@ -183,7 +183,7 @@ private ResolutionDetails<T> ResolveValue<T>(string flagKey, T defaultValue, Eva | |||
| // convert the EvaluationContext object into something the JsonLogic evaluator can work with | |||
| dynamic contextObj = (object)ConvertToDynamicObject(targetingContext); | |||
|
|
|||
| // convery whatever is returned to a sring to try to use is an a index to Variants | |||
| // convert whatever is returned to a string to try to use it as an index to Variants | |||
There was a problem hiding this comment.
I hope I didn't write this but I fear I did 😅
toddbaert
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190