Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Flagsmith provider #91

Closed

Conversation

vpetrusevici
Copy link
Contributor

@vpetrusevici vpetrusevici commented Oct 18, 2023

This PR

Adds new library project for Flagsmith provider with implementation and tests

Related Issues

#90

Notes

We are going to use OpenFeature and Flagsmith in our projects. Unfortunately dotnet-sdk-contrib doesn't have Flagsmith provider, so i implemented it.

Follow-up Tasks

  • Implement
  • Add unit tests for general funcations
  • Add unit tests for using OpenFeature evaluation context
  • Review from Flagsmith team
  • Test

How to test

Just create FlagsmithProvider using FlagsmithClient or FlagsmithConfiguration according to https://github.com/Flagsmith/flagsmith-dotnet-client/tree/main/Example

@vpetrusevici vpetrusevici requested a review from a team as a code owner October 18, 2023 19:32
Signed-off-by: Vladimir Petrusevici <[email protected]>
@toddbaert
Copy link
Member

@vpetrusevici could you perhaps force push this branch to vpetrusevici:develop? If you do that, you should be able to re-open the old pull request so we can get the review back.

@vpetrusevici
Copy link
Contributor Author

@vpetrusevici could you perhaps force push this branch to vpetrusevici:develop? If you do that, you should be able to re-open the old pull request so we can get the review back.

done, thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants