Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom seed in fractional op #136

Merged

Conversation

colebaileygit
Copy link
Contributor

@colebaileygit colebaileygit commented Mar 30, 2024

This PR

  • updates fractional schema to accept complex rules as first argument to override targeting so that we can support using cat and other rules to provide custom seeds to randomisation

Related Issues

open-feature/flagd#1264
resolves open-feature/flagd#1265

Notes

Follow-up Tasks

How to test

see open-feature/flagd#1266

@colebaileygit colebaileygit requested a review from a team as a code owner March 30, 2024 20:10
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I would like to wait for @toddbaert to approve before we merge.

Signed-off-by: Kavindu Dodanduwa <[email protected]>
@beeme1mr beeme1mr merged commit ea4f119 into open-feature:main Apr 8, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
beeme1mr pushed a commit that referenced this pull request Apr 8, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>json/json-schema: 0.2.3</summary>

##
[0.2.3](json/json-schema-v0.2.2...json/json-schema-v0.2.3)
(2024-04-08)


### ✨ New Features

* allow custom seed in fractional op
([#136](#136))
([ea4f119](ea4f119))
* support chainable if conditions
([#138](#138))
([cc7832a](cc7832a))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow nested operators in fractional schema
4 participants