Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test multiple fractional flags with shared seed #115

Merged
merged 7 commits into from
Apr 6, 2024
Merged

feat: test multiple fractional flags with shared seed #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3427ec0
test multiple fractional flags with shared seed
colebaileygit Mar 30, 2024
2c792b8
update to use cat and explicit seeds
colebaileygit Apr 1, 2024
5537cbc
Merge branch 'open-feature:main' into feat/fractional-custom-seed
colebaileygit Apr 2, 2024
12e3434
fix: change fractional int edge case to return real variant instead o…
colebaileygit Apr 2, 2024
4a5a002
Update flags/custom-ops.json
toddbaert Apr 5, 2024
4a4d855
Update gherkin/flagd-json-evaluator.feature
toddbaert Apr 5, 2024
57a7b43
Update gherkin/flagd-json-evaluator.feature
toddbaert Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion flags/custom-ops.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,56 @@
"defaultVariant": "wild",
"targeting": {
"fractional": [
{ "var": "user.name" },
{"cat": [
{ "var": "$flagd.flagKey" },
{ "var": "user.name" }
]},
[ "clubs", 25 ],
[ "diamonds", 25 ],
[ "hearts", 25 ],
[ "spades", 25 ]
]
}
},
"fractional-flag-A-shared-seed": {
"state": "ENABLED",
"variants": {
"clubs": "clubs",
"diamonds": "diamonds",
"hearts": "hearts",
"spades": "spades",
"wild": "wild"
},
"defaultVariant": "wild",
"targeting": {
"fractional": [
{ "cat": [
"shared-seed",
{ "var": "user.name" }
]},
[ "clubs", 25 ],
[ "diamonds", 25 ],
[ "hearts", 25 ],
[ "spades", 25 ]
]
}
},
"fractional-flag-B-shared-seed": {
"state": "ENABLED",
"variants": {
"clubs": "ace-of-clubs",
"diamonds": "ace-of-diamonds",
"hearts": "ace-of-hearts",
"spades": "ace-of-spades",
"wild": "wild"
},
"defaultVariant": "wild",
"targeting": {
"fractional": [
{ "cat": [
"shared-seed",
{ "var": "user.name" }
]},
[ "clubs", 25 ],
[ "diamonds", 25 ],
[ "hearts", 25 ],
Expand Down
24 changes: 23 additions & 1 deletion gherkin/flagd-json-evaluator.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,29 @@ Feature: flagd json evaluation
| "queen" | "clubs" |
| "ten" | "diamonds" |
| "nine" | "hearts" |
| 3 | "wild" |
| 3 | "diamonds" |

Scenario Outline: Fractional operator with shared seed
When a string flag with key "fractional-flag-A-shared-seed" is evaluated with default value "fallback"
And a context containing a nested property with outer key "user" and inner key "name", with value <name>
Then the returned value should be <value>
Examples:
| name | value |
| "jack" | "hearts" |
| "queen" | "spades" |
| "ten" | "hearts" |
| "nine" | "diamonds" |

Scenario Outline: Second fractional operator with shared seed
When a string flag with key "fractional-flag-B-shared-seed" is evaluated with default value "fallback"
And a context containing a nested property with outer key "user" and inner key "name", with value <name>
Then the returned value should be <value>
Examples:
| name | value |
| "jack" | "ace-of-hearts" |
| "queen" | "ace-of-spades" |
| "ten" | "ace-of-hearts" |
| "nine" | "ace-of-diamonds" |

Scenario Outline: Substring operators
When a string flag with key "starts-ends-flag" is evaluated with default value "fallback"
Expand Down
Loading