feat: fractional non-percentage and shorthand #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jun 28, 2024
Comment on lines
+33
to
+36
| Scenario Outline: Fractional operator shorthand | ||
| When a string flag with key "fractional-flag-shorthand" is evaluated with default value "fallback" | ||
| And a context containing a targeting key with value <targeting key> | ||
| Then the returned value should be <value> |
There was a problem hiding this comment.
These bindings already exist, so no new implementation code needs to be written. Consumers can just update the flagd image and the submodule containing the gherkin.
toddbaert
requested review from
beeme1mr,
thisthat,
bacherfl,
aepfli and
DBlanchard88
Kavindu-Dodan
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new fractional test and assertions. These don't require any new test implementation in consumers since they use existing clauses/bindings.
The new flag tests:
1if no weight is passedI tested this locally with Java and it passes both RPC and in-process.