fix: correct assertions for shorthand targeting #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first wrote these assertions, I had incorrectly setup the cuke bindings in the JS repo where I tested it; I was setting the targeting key to
"[email protected]"
(including the quotes!!!) which obviously resulted in a different assignment. Then when I started implementing these tests in other repos, nothing worked 😅These are the actual correct responses, which you can test in flagd: