feat!: remove gherkin, add events support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
beeme1mr,
thisthat,
bacherfl and
Kavindu-Dodan
toddbaert
commented
Aug 29, 2023
| @@ -0,0 +1,22 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
We need this little wrapper script to start our flags/change-flag.sh script in the background, and to forward signals to flagd so we can gracefully shut down.
toddbaert
commented
Aug 29, 2023
| @@ -0,0 +1,15 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
This script just swaps the value of the flag in changing-flag.json once a second.
toddbaert
commented
Aug 29, 2023
|
|
||
| COPY testing-flags.json testing-flags.json | ||
| FROM busybox:1.36 |
There was a problem hiding this comment.
busybox because we need some basic tools and a shell.
There was a problem hiding this comment.
This is fine. Final image is ~60MB
Kavindu-Dodan
approved these changes
Aug 29, 2023
Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
requested changes
Aug 29, 2023
|
beeme1mr
approved these changes
Aug 30, 2023
Kavindu-Dodan
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a means of testing events to the flagd-testbed container image.