Skip to content

Commit

Permalink
add optional custom seed override for fractional op
Browse files Browse the repository at this point in the history
Signed-off-by: Cole Bailey <[email protected]>
  • Loading branch information
colebaileygit committed Mar 30, 2024
1 parent 2a185fd commit ce8faab
Show file tree
Hide file tree
Showing 4 changed files with 133 additions and 3 deletions.
9 changes: 8 additions & 1 deletion core/pkg/evaluator/fractional.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,19 @@ func parseFractionalEvaluationData(values, data any) (string, []fractionalEvalua
}
}

seed, ok := valuesArray[0].(string)
if ok {
valuesArray = valuesArray[1:]
} else {
seed = properties.FlagKey
}

feDistributions, err := parseFractionalEvaluationDistributions(valuesArray)
if err != nil {
return "", nil, err
}

return fmt.Sprintf("%s%s", properties.FlagKey, bucketBy), feDistributions, nil
return fmt.Sprintf("%s%s", seed, bucketBy), feDistributions, nil
}

func parseFractionalEvaluationDistributions(values []any) ([]fractionalEvaluationDistribution, error) {
Expand Down
123 changes: 123 additions & 0 deletions core/pkg/evaluator/fractional_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func TestFractionalEvaluation(t *testing.T) {
{
"fractional": [
{"var": "email"},
{"var": "$flagd.flagKey"},
[
"red",
25
Expand All @@ -51,6 +52,35 @@ func TestFractionalEvaluation(t *testing.T) {
]
}`),
},
"customSeededHeaderColor": {
State: "ENABLED",
DefaultVariant: "red",
Variants: map[string]any{
"red": "#FF0000",
"blue": "#0000FF",
"green": "#00FF00",
"yellow": "#FFFF00",
},
Targeting: []byte(`{
"if": [
{
"in": ["@faas.com", {
"var": ["email"]
}]
},
{
"fractional": [
{"var": "email"},
"my-seed",
["red",25],
["blue",25],
["green",25],
["yellow",25]
]
}, null
]
}`),
},
},
}

Expand Down Expand Up @@ -103,6 +133,46 @@ func TestFractionalEvaluation(t *testing.T) {
expectedValue: "#00FF00",
expectedReason: model.TargetingMatchReason,
},
"[email protected] with custom seed": {
flags: flags,
flagKey: "customSeededHeaderColor",
context: map[string]any{
"email": "[email protected]",
},
expectedVariant: "green",
expectedValue: "#00FF00",
expectedReason: model.TargetingMatchReason,
},
"[email protected] with custom seed": {
flags: flags,
flagKey: "customSeededHeaderColor",
context: map[string]any{
"email": "[email protected]",
},
expectedVariant: "red",
expectedValue: "#FF0000",
expectedReason: model.TargetingMatchReason,
},
"[email protected] with custom seed": {
flags: flags,
flagKey: "customSeededHeaderColor",
context: map[string]any{
"email": "[email protected]",
},
expectedVariant: "green",
expectedValue: "#00FF00",
expectedReason: model.TargetingMatchReason,
},
"[email protected] with custom seed": {
flags: flags,
flagKey: "customSeededHeaderColor",
context: map[string]any{
"email": "[email protected]",
},
expectedVariant: "green",
expectedValue: "#00FF00",
expectedReason: model.TargetingMatchReason,
},
"[email protected] with different flag key": {
flags: Flags{
Flags: map[string]model.Flag{
Expand Down Expand Up @@ -156,6 +226,59 @@ func TestFractionalEvaluation(t *testing.T) {
expectedValue: "#FF0000",
expectedReason: model.TargetingMatchReason,
},
"[email protected] with default seed": {
flags: Flags{
Flags: map[string]model.Flag{
"headerColor": {
State: "ENABLED",
DefaultVariant: "red",
Variants: map[string]any{
"red": "#FF0000",
"blue": "#0000FF",
"green": "#00FF00",
"yellow": "#FFFF00",
},
Targeting: []byte(`{
"if": [
{
"in": ["@faas.com", {
"var": ["email"]
}]
},
{
"fractional": [
{"var": "email"},
[
"red",
25
],
[
"blue",
25
],
[
"green",
25
],
[
"yellow",
25
]
]
}, null
]
}`),
},
},
},
flagKey: "headerColor",
context: map[string]any{
"email": "[email protected]",
},
expectedVariant: "green",
expectedValue: "#00FF00",
expectedReason: model.TargetingMatchReason,
},
"non even split": {
flags: Flags{
Flags: map[string]model.Flag{
Expand Down
2 changes: 1 addition & 1 deletion schemas
2 changes: 1 addition & 1 deletion test-harness

0 comments on commit ce8faab

Please sign in to comment.