fix: validate that a flag key is valid UTF-8 & implemented fuzzing tests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will rebase once 1.18 is merged: #140 |
skyerus
force-pushed
the
issue-127_fuzzing
branch
from
7be4962
to
ba50739
Compare
beeme1mr
approved these changes
Jan 25, 2023
skyerus
force-pushed
the
issue-127_fuzzing
branch
from
ba50739
to
f9cb653
Compare
toddbaert
reviewed
Jan 26, 2023
|
Overall looks good. One suggestion, let's add few more fuzz seeds. For example, flag keys with mix cases, include numbers (A-z0-9) plus special characters if needed. Plus the same for default variant to match the type. |
Signed-off-by: Skye Gill <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
skyerus
force-pushed
the
issue-127_fuzzing
branch
from
f9cb653
to
6a5ff5d
Compare
Thanks! Good suggestion, done :) |
Kavindu-Dodan
approved these changes
Jan 27, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #127
Notes
Follow-up Tasks
How to test