Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update broken comment link #202

Merged
merged 2 commits into from
Jul 20, 2023
Merged

chore: update broken comment link #202

merged 2 commits into from
Jul 20, 2023

Conversation

diegomarangoni
Copy link
Contributor

This PR

  • fixes broken link docs reference

@diegomarangoni diegomarangoni requested a review from a team as a code owner July 20, 2023 08:48
@diegomarangoni
chore: update broken comment link
7281f74 
Signed-off-by: Diego Marangoni <[email protected]>
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #202 (4c9cfbd) into main (dda3ff1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files           9        9           
  Lines        1074     1074           
=======================================
  Hits          848      848           
  Misses        204      204           
  Partials       22       22
Impacted Files Coverage Δ
pkg/openfeature/evaluation_context.go 80.95% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

beeme1mr
beeme1mr approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! I will update this link to point to the docs instead of the GitHub because it's easier to read, and we'll configure redirects if the path ever changes.

pkg/openfeature/evaluation_context.go Outdated Show resolved Hide resolved
@beeme1mr beeme1mr merged commit b0c4fd0 into open-feature:main Jul 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspoignant thomaspoignant thomaspoignant approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegomarangoni @beeme1mr @thomaspoignant