feat: loosen test instance interface to support various test frameworks #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
approved these changes
Feb 4, 2025
beeme1mr
changed the title
Signed-off-by: ekarlso <[email protected]>
ekarlso
force-pushed
the
use-testing-tb
branch
from
454d168 to
16323ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 13 13
Lines 1372 1372
=======================================
Hits 1192 1192
Misses 156 156
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
beeme1mr
changed the title
toddbaert
approved these changes
Feb 4, 2025
beeme1mr
changed the title
ekarlso
pushed a commit
to ekarlso/go-sdk
that referenced
this pull request
Feb 4, 2025
…ks (open-feature#317) Switch to `interface{ Name() string }` since testing.BB has `private` which blocks it from working. Signed-off-by: ekarlso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
See slack thread for context - https://cloud-native.slack.com/archives/C06HAN9KP9Q/p1738616572605649
Related Issues
Fixes #1234523
Notes
Follow-up Tasks
How to test