chore: flaky test #1169
Merged
chore: flaky test #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
chore/flaky-tests
branch
from
48cd5f4
to
fe0ad3b
Compare
|
toddbaert
commented
Oct 18, 2024
| @@ -42,7 +42,7 @@ void reset_logs() { | |||
| @DisplayName("should not throw exception if hook has different type argument than hookContext") | |||
| void shouldNotThrowExceptionIfHookHasDifferentTypeArgumentThanHookContext() { | |||
| OpenFeatureAPI api = OpenFeatureAPI.getInstance(); | |||
| api.setProvider("shouldNotThrowExceptionIfHookHasDifferentTypeArgumentThanHookContext", new DoSomethingProvider()); | |||
| api.setProviderAndWait("shouldNotThrowExceptionIfHookHasDifferentTypeArgumentThanHookContext", new DoSomethingProvider()); | |||
There was a problem hiding this comment.
This test isn't helped by using the non-blocking provider setter here. There are a few tests where we want to not block (to assert behaviors about the SDK before the provider is ready, for instance) but this is not one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
============================================
+ Coverage 93.01% 93.20% +0.19%
- Complexity 436 437 +1
============================================
Files 40 40
Lines 1016 1016
Branches 84 84
============================================
+ Hits 945 947 +2
+ Misses 43 42 -1
+ Partials 28 27 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
beeme1mr
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test in this suite use the non-blocking provider set, which can result in flakiness in these cases since we aren't listening for a ready event.