chore: add todos, fix submodule pull #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #543 +/- ##
=========================================
Coverage 95.23% 95.23%
Complexity 329 329
=========================================
Files 31 31
Lines 755 755
Branches 37 37
=========================================
Hits 719 719
Misses 19 19
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -523,7 +525,7 @@ | |||
| <argument>submodule</argument> | |||
| <argument>update</argument> | |||
| <argument>--init</argument> | |||
| <argument>--recursive</argument> | |||
| <argument>test-harness</argument> | |||
There was a problem hiding this comment.
+1 for specific submodule pull
Kavindu-Dodan
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some TODOs related to #523.
Also pulls a specific submodule instead of all of them via recursive, since this can cause failures when multiple jobs pull submodules at the same time.