-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: various gherkin improvements for e2e tests #1008
chore: various gherkin improvements for e2e tests #1008
Conversation
794c735
to
f9ba61f
Compare
okay, i failed here hard, i did not check the api, and the webclient and the server client do not have an overlapping api - hence that part of this improvements are not worth it. eg. the normalization witthin flagd-core. I could generate an wrapper around it, to be passed on to the stepdefinitions, but imho i do not think that this is worth it. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
3c4e71a
to
1e5c631
Compare
Signed-off-by: Simon Schrottner <[email protected]>
1e5c631
to
07e27ce
Compare
Signed-off-by: Simon Schrottner <[email protected]>
@beeme1mr @toddbaert I think this is ready. I just have had no time to investigate why the flags changed test for flagd-web is failing. If I find the time I will investigate. If you on the other hand read this, before my next message and have more insights (maybe not implement fully) just let me know ;) |
Okay it seems like we are not providing a list of changed flags - as we are reloading all of them - makes sense. The question is, if it is worth checking if the flag has changed from previous calls. Or if getting the event alone is test enough |
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Will check this out tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! I tested this locally a few ways, the right things are being tested and almost everything looks right.
A few minor nits I left where we are logging the wrong thing.
My only blocker is this.
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
b92267a
to
a2e720a
Compare
Signed-off-by: Simon Schrottner <[email protected]>
a2e720a
to
af7956d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please address the linting issues before merging. Nice job!
Amazing! |
This PR
Related Issues
Fixes #986
Follow-up Tasks
currently the path for the gherkin feature files is 'hardcoded' and not autmatically resolved relatively to the test (maybe somebody has a good idea for this)