Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add kind node image matrix for end to end testing #502

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

L3o-pold
Copy link
Contributor

@L3o-pold L3o-pold commented Jul 22, 2023

This PR

  • Add kind node image matrix for end to end testing

Related Issues

Following the discussion here: #500

Notes

Follow-up Tasks

How to test

@L3o-pold L3o-pold requested a review from a team as a code owner July 22, 2023 13:26
@L3o-pold L3o-pold changed the title ci: add kind node image matrix add kind node image matrix for end to end testing Jul 22, 2023
@L3o-pold L3o-pold changed the title add kind node image matrix for end to end testing test: add kind node image matrix for end to end testing Jul 22, 2023
@L3o-pold L3o-pold changed the title test: add kind node image matrix for end to end testing ci: add kind node image matrix for end to end testing Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #502 (0d54bbf) into main (786d511) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files          22       22           
  Lines        1393     1393           
=======================================
  Hits         1151     1151           
  Misses        205      205           
  Partials       37       37           
Flag Coverage Δ
unit-tests 82.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@L3o-pold L3o-pold force-pushed the add-kind-node-image-matrix branch 2 times, most recently from 7ee619d to d669ffc Compare July 25, 2023 13:29
@L3o-pold L3o-pold requested a review from toddbaert July 25, 2023 13:29
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Leopold Jacquot <[email protected]>
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @L3o-pold !

@toddbaert toddbaert merged commit 1620a08 into open-feature:main Jul 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants