Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use admission webhook namespace if pod namespace is empty #503

Merged

Conversation

L3o-pold
Copy link
Contributor

This PR

Fix issue with admission webhook on older k8s version

Related Issues

Fixes #500

Notes

Follow-up Tasks

We then can say open-feature-operator is working on k8s >= 1.22

How to test

I tested on kind with a 1.22 image (image: kindest/node:v1.22.9) .

kind create cluster --config ./test/e2e/kind-cluster.yml
kind load docker-image local-image-tag:latest
IMG=local-image-tag:latest make deploy-operator
IMG=local-image-tag:latest make e2e-test

@L3o-pold L3o-pold requested a review from a team as a code owner July 26, 2023 15:04
@L3o-pold L3o-pold force-pushed the fix-webhook-for-older-k8s-version branch from d4c82fd to 27a5a40 Compare July 26, 2023 15:06
@L3o-pold L3o-pold force-pushed the fix-webhook-for-older-k8s-version branch from 27a5a40 to 94983d4 Compare July 27, 2023 12:14
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #503 (94983d4) into main (1620a08) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   82.62%   82.67%   +0.04%     
==========================================
  Files          22       22              
  Lines        1393     1397       +4     
==========================================
+ Hits         1151     1155       +4     
  Misses        205      205              
  Partials       37       37              
Files Changed Coverage Δ
webhooks/pod_webhook.go 89.63% <100.00%> (+0.25%) ⬆️
Flag Coverage Δ
unit-tests 82.67% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@beeme1mr beeme1mr merged commit ffd3e0a into open-feature:main Jul 28, 2023
12 checks passed
@L3o-pold L3o-pold deleted the fix-webhook-for-older-k8s-version branch August 3, 2023 11:23
@L3o-pold
Copy link
Contributor Author

L3o-pold commented Dec 1, 2023

d234410 reverted this PR...

@beeme1mr
Copy link
Member

beeme1mr commented Dec 1, 2023

Hi @L3o-pold, sorry about that! We've reintroduced this feature in v0.5.1 and expanded our test coverage to ensure it isn't accidentally removed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants