Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add otel collector uri flag #513

Merged

Conversation

L3o-pold
Copy link
Contributor

@L3o-pold L3o-pold commented Aug 3, 2023

This PR

  • adds otelCollectorUri attribute for FlagSourceConfiguration CRD to configure OTEL collector

Related Issues

Fixes #512

Notes

Follow-up Tasks

How to test

@L3o-pold L3o-pold requested a review from a team as a code owner August 3, 2023 11:26
@L3o-pold L3o-pold force-pushed the add-otel-collector-uri-flag branch 2 times, most recently from 576ffa0 to e4d9fde Compare August 3, 2023 11:29
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #513 (85ead0a) into main (e740068) will increase coverage by 0.03%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   82.67%   82.70%   +0.03%     
==========================================
  Files          22       22              
  Lines        1397     1417      +20     
==========================================
+ Hits         1155     1172      +17     
- Misses        205      207       +2     
- Partials       37       38       +1     
Files Changed Coverage Δ
...pis/core/v1alpha2/flagsourceconfiguration_types.go 100.00% <ø> (ø)
...pis/core/v1alpha3/flagsourceconfiguration_types.go 100.00% <ø> (ø)
...pis/core/v1alpha1/flagsourceconfiguration_types.go 97.09% <25.00%> (-1.72%) ⬇️
...ore/v1alpha2/flagsourceconfiguration_conversion.go 100.00% <100.00%> (ø)
...ore/v1alpha3/flagsourceconfiguration_conversion.go 100.00% <100.00%> (ø)
controllers/common/flagd-injector.go 90.88% <100.00%> (+0.36%) ⬆️
Flag Coverage Δ
unit-tests 82.70% <85.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kavindu-Dodan
Copy link
Contributor

@L3o-pold thank you for this contribution 🎉

Only thing missing from my point of view is the readme update for helm chart - https://github.com/open-feature/open-feature-operator/blob/main/chart/open-feature-operator/README.md#sidecar-configuration

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@L3o-pold L3o-pold force-pushed the add-otel-collector-uri-flag branch 2 times, most recently from a65d783 to 22a21c5 Compare August 3, 2023 20:25
@L3o-pold L3o-pold force-pushed the add-otel-collector-uri-flag branch from 22a21c5 to 6f4cf2a Compare August 3, 2023 21:47
@L3o-pold L3o-pold force-pushed the add-otel-collector-uri-flag branch from 6f4cf2a to ff393c1 Compare August 4, 2023 07:26
Signed-off-by: Leopold Jacquot <[email protected]>
@L3o-pold L3o-pold force-pushed the add-otel-collector-uri-flag branch from ff393c1 to 85ead0a Compare August 4, 2023 07:29
@Kavindu-Dodan Kavindu-Dodan merged commit 31d8d5a into open-feature:main Aug 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow OTEL collector
3 participants