Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use v1beta1 in operator logic #539

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 7, 2023

This PR

  • uses v1beta1 in operator logic
  • cleanup of orphaned/deprecated functionality
  • remove FeatureFlag controller
  • remove duplications
  • remove unneeded tests
  • add more tests for uncovered use-cases
  • minor workflow adaptation of e2e tests
  • utilize common functions/constants to common package
  • refactor common package
  • remove unneeded config files from config folder
  • cleanup webhook logic

Related Issues

Fixes #531

Depends on

open-feature/flagd#997

Notes

Currently the OFO is using custom build images of flagD, this will be chaned after open-feature/flagd#997 will be merged and released

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #539 (f7c89e6) into main (e3c8b42) will increase coverage by 3.92%.
The diff coverage is 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   77.94%   81.86%   +3.92%     
==========================================
  Files          10        7       -3     
  Lines        1020      805     -215     
==========================================
- Hits          795      659     -136     
+ Misses        189      118      -71     
+ Partials       36       28       -8     
Files Coverage Δ
common/common.go 100.00% <100.00%> (ø)
common/flagdproxy/flagdproxy.go 82.18% <100.00%> (ø)
common/utils/utils.go 38.09% <100.00%> (ø)
webhooks/common.go 100.00% <100.00%> (ø)
webhooks/pod_webhook.go 82.35% <93.33%> (-7.29%) ⬇️
common/flagdinjector/flagdinjector.go 90.22% <82.75%> (ø)
controllers/core/featureflagsource/controller.go 46.37% <66.66%> (ø)
Flag Coverage Δ
unit-tests 81.86% <90.24%> (+3.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kavindu-Dodan
Copy link
Contributor

Great progress. Needs to fix some conflicts and address few comments. Once done we can go for the release.

Proposal - we should make this a breaking change

@toddbaert toddbaert self-requested a review November 15, 2023 20:56
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Amazing.

Approving, pending conflict resolution and this.

@odubajDT odubajDT changed the title feat: use v1beta1 in operator logic feat!: use v1beta1 in operator logic Nov 16, 2023
@odubajDT odubajDT force-pushed the feat/531/v1beta1 branch 2 times, most recently from be5eda6 to c8c6bda Compare November 16, 2023 08:40
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
webhooks/common.go Outdated Show resolved Hide resolved
@odubajDT odubajDT merged commit d234410 into open-feature:main Nov 16, 2023
13 checks passed
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of v1beta1 in OFO logic
4 participants