-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor code to decrease complexity #554
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 84.27% 87.91% +3.63%
==========================================
Files 10 10
Lines 935 927 -8
==========================================
+ Hits 788 815 +27
+ Misses 121 89 -32
+ Partials 26 23 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
e726648
to
aeb529c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few variables that use improper casing of flagd. It would be nice to address them either in this PR or in a follow up.
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
3445822
to
c3b92b3
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: odubajDT <[email protected]>
Fixes #533
Changes
nolint
comments (where it makes sense)common/constants
package tocommon
right next to the rest of constantscommon
packageFlagdProxyHandler
flagdinjector