Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update open-feature/flagd #600

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 29, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
ghcr.io/open-feature/flagd minor v0.7.2 -> v0.9.0
ghcr.io/open-feature/flagd-proxy minor v0.3.2 -> v0.5.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

open-feature/flagd (ghcr.io/open-feature/flagd-proxy)

v0.4.2

Compare Source

🧹 Chore
🐛 Bug Fixes
✨ New Features

v0.4.1

Compare Source

🔄 Refactoring
🧹 Chore
🐛 Bug Fixes

v0.4.0

Compare Source

⚠ BREAKING CHANGES
  • Use OTel to export metrics (metric name changes) (#​419)
🧹 Chore
🐛 Bug Fixes
  • deps: update kubernetes packages to v0.26.2 (#​450) (2885227)
  • deps: update module github.com/bufbuild/connect-go to v1.5.2 (#​416) (feb7f04)
  • deps: update module github.com/open-feature/go-sdk-contrib/providers/flagd to v0.1.9 (#​427) (42d2705)
  • deps: update module github.com/open-feature/open-feature-operator to v0.2.29 (#​429) (b7fae81)
  • deps: update module github.com/stretchr/testify to v1.8.2 (#​440) (ab3e674)
  • deps: update module golang.org/x/net to v0.7.0 (#​410) (c6133b6)
  • deps: update module sigs.k8s.io/controller-runtime to v0.14.5 (#​454) (f907f11)
  • remove non-error error log from parseFractionalEvaluationData (#​446) (34aca79)
✨ New Features
📚 Documentation

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 29, 2024 22:58
@renovate renovate bot added the renovate label Jan 29, 2024
@renovate renovate bot force-pushed the renovate/open-featureflagd branch 2 times, most recently from c205a4f to 25b6223 Compare February 6, 2024 19:11
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4476e2) 88.22% compared to head (9f272d5) 88.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files          10       10           
  Lines         960      960           
=======================================
  Hits          847      847           
  Misses         88       88           
  Partials       25       25           
Files Coverage Δ
controllers/core/featureflagsource/controller.go 51.31% <ø> (ø)
Flag Coverage Δ
unit-tests 88.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@renovate renovate bot force-pushed the renovate/open-featureflagd branch 3 times, most recently from 69773c7 to 548ff81 Compare February 20, 2024 19:03
@renovate renovate bot force-pushed the renovate/open-featureflagd branch from 548ff81 to 344fa9e Compare February 20, 2024 19:14
Signed-off-by: Todd Baert <[email protected]>
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates OFO to use the latest flagd and flagd-proxy versions, which use the new protos.

Since OFO doesn't yet support in-process providers, I think this should "just work", since flagd uses the new sync proto (as a client) and can talk to flagd-proxy which uses the new proto (as a server).

flagd itself still supports both the old and new evaluation protos, so for end-users nothing breaks with this (their workloads can still talk to flagd just fine).

Signed-off-by: Todd Baert <[email protected]>
@Kavindu-Dodan
Copy link
Contributor

@toddbaert renovate failed as current regex doesn't cover above files [1]. I think this is due to recent refactorings which didn't update the pattern. I think we should update this to include any .go file

[1] - https://github.com/open-feature/open-feature-operator/blob/main/renovate.json#L41

@toddbaert
Copy link
Member

@toddbaert renovate failed as current regex doesn't cover above files [1]. I think this is due to recent refactorings which didn't update the pattern. I think we should update this to include any .go file

[1] - https://github.com/open-feature/open-feature-operator/blob/main/renovate.json#L41

Ah, I see. Thanks. I'm fine with that. Do you think we should include it here or in a new PR?

Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kavindu-Dodan
Copy link
Contributor

Kavindu-Dodan commented Feb 20, 2024

@toddbaert renovate failed as current regex doesn't cover above files [1]. I think this is due to recent refactorings which didn't update the pattern. I think we should update this to include any .go file
[1] - https://github.com/open-feature/open-feature-operator/blob/main/renovate.json#L41

Ah, I see. Thanks. I'm fine with that. Do you think we should include it here or in a new PR?

I will open a quick PR for this :)

Update - please see here #607

Copy link
Contributor Author

renovate bot commented Feb 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@toddbaert toddbaert merged commit 0e03f47 into main Feb 21, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
@toddbaert toddbaert deleted the renovate/open-featureflagd branch February 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants