fix!: remove flagdResourceEnabled #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
May 29, 2024
toddbaert
force-pushed
the
fix/remove-flagdResourceEnabled
branch
from
fc33a8b
to
51b678d
Compare
Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
approved these changes
May 29, 2024
|
I am fine with removing the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #651, I started down the path of maintaining 2 roles and 2 rolebindings, one that controls the extra stuff we need when
managerConfig.flagdResourceEnabledis enabled, but after running through some proposed tutorials and dealing with this additional complexity, I honestly think the entire idea ofmanagerConfig.flagdResourceEnabledis not worth it. My reasoning is that it's easy to restrict the creation of flagd CR instances entirely (or instances with ingresses) through many different tools and policies, since these are not created automatically by annotations like some of our other resources. I just don't think we need to control them at the OFO install level.Sorry @bacherfl for the wasted time here, since this was initially my idea. 😔
Fixes: #651
I tested this locally and it works as expected with Helm.