fix: Add missing poddisruption budget permissions in manager cluster role #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wondertroy
changed the title
wondertroy
force-pushed
the
fix/missing-rbac-poddisruptionbudget
branch
from
0b6d262
to
2cd4cc3
Compare
Background --- Open feature operator now attempts to list, create, and watch pod disruption budget resources for flagd proxy since it can now configure HA replica for flagd proxy Changes --- * update existing ClusterRole configuration to include poddisruptionbudget resource permissions for api group: policy Testing --- * manually apply changes to ClusterRole resource, change FlagSource and watch for permission errors. Retry with extra verbs until no reconcile errors were encountered. Signed-off-by: woodyh <[email protected]>
wondertroy
force-pushed
the
fix/missing-rbac-poddisruptionbudget
branch
from
2cd4cc3
to
aa3e444
Compare
xvzf
approved these changes
Oct 30, 2024
beeme1mr
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 86.51% 86.25% -0.26%
==========================================
Files 19 19
Lines 1587 1681 +94
==========================================
+ Hits 1373 1450 +77
- Misses 173 184 +11
- Partials 41 47 +6 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Add missing poddisruption budget permissions in manager cluster role
Open feature operator now attempts to list, create, and watch pod disruption budget resources for flagd proxy since it can now configure HA replica for flagd proxy
Related Issues
Fixes #717
Related to #712
Notes
How to test