Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable fail-fast behavior #90

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

tcarrio
Copy link
Member

@tcarrio tcarrio commented Jul 21, 2023

This PR

there are scenarios where some providers may fail and it may be entirely on downstream dependencies or configurations unrelated to a PR. this change allows a full PR's CI jobs to execute regardless of a failure in another job.

Related Issues

Fixes #1234523

Notes

Nothing really that special, just allows us to gather more insight into jobs that don't fail.

Follow-up Tasks

How to test

Do all CI stages run without being cancelled?

there are scenarios where some providers may fail and it may be entirely on downstream dependencies or configurations unrelated to a PR. this change allows a full PR's CI jobs to execute regardless of a failure in another job.

Signed-off-by: Tom Carrio <[email protected]>
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #90 (9f593e9) into main (684367c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files          28       28           
  Lines         422      422           
=======================================
  Hits          243      243           
  Misses        179      179           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcarrio
Copy link
Member Author

tcarrio commented Jul 21, 2023

As expected, all stages ran except for those that failed. Failures did not cause cancellations. Merging.

@tcarrio tcarrio merged commit 9041190 into main Jul 21, 2023
19 of 22 checks passed
@beeme1mr beeme1mr deleted the ci/disable-fail-fast-jobs-config branch July 21, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant