Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Nest.js SDK in backend #273

Merged
merged 7 commits into from
Jan 22, 2024
Merged

feat: use Nest.js SDK in backend #273

merged 7 commits into from
Jan 22, 2024

Conversation

lukas-reining
Copy link
Member

This PR

Adds the Nest.js SDK to the backend services.

beeme1mr
beeme1mr reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. Were you able to run this locally? I'll try and test it out this afternoon.

packages/app/src/app/app.module.ts Outdated Show resolved Hide resolved
packages/app/src/app/fibonacci/fibonacci.service.ts Outdated Show resolved Hide resolved
packages/fibonacci-service/src/app/app.module.ts Outdated Show resolved Hide resolved
@lukas-reining
Copy link
Member Author

Yes @beeme1mr, building it locally and running worked!
I will change the imports tomorrow.

@lukas-reining
feat: Use nest-sdk imports
6666ad2 
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining
Copy link
Member Author

I updated the imports @toddbaert @beeme1mr :)

beeme1mr
beeme1mr reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running into an issue building the UI. It seems to have something to do with missing webpack polyfills. I'm looking into it.

docker-compose.yaml
# build:
# dockerfile: ./packages/app/Dockerfile
# context: .
# image: ghcr.io/open-feature/playground-app:v0.13.4 # x-release-please-version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this before merging

@beeme1mr
remove unused error
c6b3883 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
add build step to ci
d8a924c 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
add shared import boundary
139cdc2 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
resolve invalid import
8cbbc9f 
Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr
Copy link
Member

I'm running into an issue building the UI. It seems to have something to do with missing webpack polyfills. I'm looking into it.

I found the issue. There was a shared library that was used both on the client and server but was importing from the Nest SDK. I've updated the imports and added a linting rule to prevent it from happening in the future.

@beeme1mr
resolve linting config issue
a62c862 
Signed-off-by: Michael Beemer <[email protected]>
@lukas-reining
Copy link
Member Author

lukas-reining commented Jan 22, 2024 •
edited
Loading

I'm running into an issue building the UI. It seems to have something to do with missing webpack polyfills. I'm looking into it.

I found the issue. There was a shared library that was used both on the client and server but was importing from the Nest SDK. I've updated the imports and added a linting rule to prevent it from happening in the future.

Mh interesting, I could build it with the former npm run temp and thought I cleaned everything before 🤔
Thank you for fixing it @beeme1mr !

@beeme1mr beeme1mr merged commit d4b18d8 into main Jan 22, 2024
3 checks passed
@beeme1mr beeme1mr deleted the feat/nestjs-sdk branch January 22, 2024 21:12
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Merged
@lukas-reining lukas-reining mentioned this pull request Jan 22, 2024
Merged
beeme1mr pushed a commit that referenced this pull request Jan 22, 2024
@github-actions
chore(main): release 0.14.0 (#268)
182c4cc 
🤖 I have created a release *beep* *boop*
---


##
[0.14.0](v0.13.4...v0.14.0)
(2024-01-22)


### 🐛 Bug Fixes

* **deps:** update dependency @harnessio/ff-javascript-client-sdk to
v1.21.0
([1ae889f](1ae889f))
* **deps:** update dependency @openfeature/open-telemetry-hooks to
^0.3.0 ([#264](#264))
([10ec74b](10ec74b))
* **deps:** update dependency flagsmith-nodejs to v3
([#226](#226))
([ddaba6d](ddaba6d))
* **deps:** update dependency react-router-dom to v6.20.1
([e233ccb](e233ccb))
* docker-compose.yaml image instead of build
([#274](#274))
([2fc3ccb](2fc3ccb))


### ✨ New Features

* client-side flags in e2e k8s demo
([#267](#267))
([c782315](c782315))
* use Nest.js SDK in backend
([#273](#273))
([d4b18d8](d4b18d8))


### 🧹 Chore

* **deps:** update dependency @emotion/react to v11.11.3
([f44f35c](f44f35c))
* **deps:** update dependency @mui/material to v5.14.20
([8a0a90b](8a0a90b))
* **deps:** update dependency @mui/material to v5.15.6
([919102d](919102d))
* **deps:** update dependency @types/node to v18.19.3
([75da9ab](75da9ab))
* **deps:** update dependency core-js to v3.34.0
([d6133d4](d6133d4))
* **deps:** update dependency ts-node to v10.9.2
([fba8985](fba8985))
* **deps:** update dependency typescript to v5.3.3
([58e00be](58e00be))
* **deps:** update eslint
([a32d0fd](a32d0fd))
* **deps:** update ghcr.io/open-feature/flagd docker tag to v0.7.2
([424fe2f](424fe2f))
* **deps:** update jaegertracing/all-in-one docker tag to v1.52.0
([aa2afbe](aa2afbe))
* **deps:** update prom/prometheus docker tag to v2.48.1
([1827862](1827862))
* **deps:** update types
([721b4e8](721b4e8))
* various dep updates
([#271](#271))
([9764184](9764184))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukas-reining @beeme1mr